Shows the info bubble when the location bar icon is clicked in the origin chip.

chrome/browser/ui/omnibox/omnibox_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines helper functions shared by the various implementations
 // of OmniboxView.
 
 #include "chrome/browser/ui/omnibox/omnibox_view.h"
 
 #include "base/strings/string16.h"
@@ skipping 74 matching lines @@
 }
 
 OmniboxView::~OmniboxView() {
 }
 
 void OmniboxView::HandleOriginChipMouseRelease() {
   // HIDE_ON_MOUSE_RELEASE only hides if there isn't any current text in the
   // Omnibox (e.g. search terms).
   if ((chrome::GetOriginChipV2HideTrigger() ==
        chrome::ORIGIN_CHIP_V2_HIDE_ON_MOUSE_RELEASE) &&
-      controller()->GetToolbarModel()->GetText().empty()) {
+      controller()->GetToolbarModel()->GetText().empty() &&
+      !model()->focused_via_location_icon()) {

[groby-ooo-7-16, 2014/04/10 21:26:09]

This feels very fragile - would it make more sense to check if the page info
bubble is showing, instead?

Also - why does the location icon decoration not need to set the focused_via
indicator?

[macourteau, 2014/04/28 19:19:24]

Would the bubble already be showing by the time we get here? If yes, how can I
test to see if it's showing?
The location icon decoration is not showing when the origin chip is showing (the
icon is drawn as part of the chip). If it's showing, that means that the origin
chip is not showing, and we don't want to change the behavior in that case.

[groby-ooo-7-16, 2014/04/30 21:55:39]

I think if you don't invoke HandleOriginChipMouseRelease when the focus came
from the location icon, you should be fine. 

I'm currently thinking that ButtonDecoration needs a PreventFocus() method. Pass
the current mouse position, have OriginChip prevent focus if it's on the
location icon.

That will also break the dependency on focused_via_location_icon state.

[groby-ooo-7-16, 2014/04/30 21:55:39]

Keeping location icon behavior the same if there's no origin chip would be a
side effect of the PreventFocus() implementation :)

[macourteau, 2014/05/01 19:04:48]

Yep, fixed.

     controller()->HideOriginChip();
   }
 }
 
 void OmniboxView::OnDidKillFocus() {
   if (chrome::ShouldDisplayOriginChipV2() &&
       !model()->user_input_in_progress()) {
     controller()->ShowOriginChip();
   }
 }
@@ skipping 116 matching lines @@
   // |profile| can be NULL in tests.
   if (profile)
     model_.reset(new OmniboxEditModel(this, controller, profile));
 }
 
 void OmniboxView::TextChanged() {
   EmphasizeURLComponents();
   if (model_.get())
     model_->OnChanged();
 }