chrome/browser/ui/toolbar/toolbar_model_impl.h - Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_model_impl.h

Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addresses nits from groby@. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/toolbar_model.h ('K') | « chrome/browser/ui/toolbar/toolbar_model.h ('k') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('j') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_model_impl.h

diff --git a/chrome/browser/ui/toolbar/toolbar_model_impl.h b/chrome/browser/ui/toolbar/toolbar_model_impl.h

index 7cec706b43e8e5afd3b05fc367d913ce3186cd5a..3fd8afee0525f9b19b9b91cec9bad13769ed9c2a 100644

--- a/chrome/browser/ui/toolbar/toolbar_model_impl.h

+++ b/chrome/browser/ui/toolbar/toolbar_model_impl.h

@@ -45,7 +45,6 @@ class ToolbarModelImpl : public ToolbarModel {

virtual base::string16 GetFormattedURL() const OVERRIDE;

virtual base::string16 GetCorpusNameForMobile() const OVERRIDE;

virtual GURL GetURL() const OVERRIDE;

- virtual bool WouldOmitURLDueToOriginChip() const OVERRIDE;

virtual bool WouldPerformSearchTermReplacement(

bool ignore_editing) const OVERRIDE;

virtual SecurityLevel GetSecurityLevel(bool ignore_editing) const OVERRIDE;

@@ -53,6 +52,8 @@ class ToolbarModelImpl : public ToolbarModel {

virtual int GetIconForSecurityLevel(SecurityLevel level) const OVERRIDE;

virtual base::string16 GetEVCertName() const OVERRIDE;

virtual bool ShouldDisplayURL() const OVERRIDE;

+ virtual bool WouldOmitURLDueToOriginChip() const OVERRIDE;

+ virtual bool ShouldShowOriginChip() const OVERRIDE;

// Returns the navigation controller used to retrieve the navigation entry

// from which the states are retrieved.