chrome/browser/ui/toolbar/toolbar_model.h - Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_model.h

Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addresses nits from groby@. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/test_toolbar_model.cc ('k') | chrome/browser/ui/toolbar/toolbar_model_impl.h » ('j') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_model.h

diff --git a/chrome/browser/ui/toolbar/toolbar_model.h b/chrome/browser/ui/toolbar/toolbar_model.h

index f4ecb749b7e6b18319fbd5d862175e64dc738d08..b168be4ae3305244b1f7b0d699c7af12457ac743 100644

--- a/chrome/browser/ui/toolbar/toolbar_model.h

+++ b/chrome/browser/ui/toolbar/toolbar_model.h

@@ -97,6 +97,10 @@ class ToolbarModel {

// wouldn't have displayed a URL to begin with (e.g. for the NTP).

virtual bool WouldOmitURLDueToOriginChip() const = 0;

+ // Returns true if the origin should be shown based on the current state of

+ // the ToolbarModel.

+ virtual bool ShouldShowOriginChip() const = 0;

Peter Kasting 2014/05/05 22:39:04 Make this non-virtual and eliminate the test_toolb

macourteau 2014/05/08 21:35:55 Done.

// Whether the text in the omnibox is currently being edited.

void set_input_in_progress(bool input_in_progress) {

input_in_progress_ = input_in_progress;