Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 2336203002: [Interpreter] Add an unsigned immediate operand type (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-decoder.cc » ('j') | src/interpreter/interpreter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index 0220c2bd7dfc1340a8323cc29147721c27d5a83b..146de2250c22baadd6e4fd058cb710a7b81cf143 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -782,10 +782,9 @@ bool BytecodeArrayBuilder::OperandsAreValid(
}
break;
case OperandType::kIdx:
- // TODO(oth): Consider splitting OperandType::kIdx into two
- // operand types. One which is a constant pool index that can
- // be checked, and the other is an unsigned value.
+ // TODO(leszeks): Check constant pool index.
rmcilroy 2016/09/13 12:05:57 These still aren't always constant pool indexes (t
Leszek Swirski 2016/09/13 14:03:23 Done, updated the todo.
break;
+ case OperandType::kUImm:
case OperandType::kImm:
break;
case OperandType::kMaybeReg:
« no previous file with comments | « no previous file | src/interpreter/bytecode-decoder.cc » ('j') | src/interpreter/interpreter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698