[Interpreter] Add an unsigned immediate operand type

src/interpreter/bytecode-array-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-array-builder.h"
 
 #include "src/globals.h"
 #include "src/interpreter/bytecode-array-writer.h"
 #include "src/interpreter/bytecode-dead-code-optimizer.h"
 #include "src/interpreter/bytecode-label.h"
@@ skipping 764 matching lines @@
           return false;
         }
         break;
       case OperandType::kRuntimeId:
         if (Bytecodes::SizeForUnsignedOperand(operands[i]) >
             OperandSize::kShort) {
           return false;
         }
         break;
       case OperandType::kIdx:
-        // TODO(oth): Consider splitting OperandType::kIdx into two
-        // operand types. One which is a constant pool index that can
-        // be checked, and the other is an unsigned value.
+        // TODO(leszeks): Check constant pool index.

[rmcilroy, 2016/09/13 12:05:57]

These still aren't always constant pool indexes (they are also used for context
slots and type-feedback-vector slots I think), so we would still need to split
it if we wanted this check.

[Leszek Swirski, 2016/09/13 14:03:23]

Done, updated the todo.

         break;
+      case OperandType::kUImm:
       case OperandType::kImm:
         break;
       case OperandType::kMaybeReg:
         if (Register::FromOperand(operands[i]) == Register(0)) {
           break;
         }
       // Fall-through to kReg case.
       case OperandType::kReg:
       case OperandType::kRegOut: {
         Register reg = Register::FromOperand(operands[i]);
@@ skipping 197 matching lines @@
       return Bytecode::kTailCall;
     default:
       UNREACHABLE();
   }
   return Bytecode::kIllegal;
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8