Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2336113003: Revert of cc: Plumb the monitor color profile to renderer for rasterization (Closed)

Created:
4 years, 3 months ago by Yuta Kitamura
Modified:
4 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, hubbe, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Plumb the monitor color profile to renderer for rasterization (patchset #6 id:100001 of https://codereview.chromium.org/2325773003/ ) Reason for revert: Suspected cause of the following MSAN failure. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12218 19:03:27.700 29717 ==4==WARNING: MemorySanitizer: use-of-uninitialized-value 19:03:27.700 29717 #0 0x7853dbe in computeTypeMask third_party/skia/src/core/SkMatrix44.cpp:59:23 19:03:27.700 29717 #1 0x7858825 in getType third_party/skia/include/core/SkMatrix44.h:208:31 19:03:27.700 29717 #2 0x7858825 in setConcat third_party/skia/src/core/SkMatrix44.cpp:378:0 19:03:27.700 29717 #3 0x76f8840 in operator*= ui/gfx/transform.h:253:5 19:03:27.700 29717 #4 0x76f8840 in ColorSpaceToColorSpaceTransform ui/gfx/color_transform.cc:563:0 19:03:27.700 29717 #5 0x76f78de in NewColorTransform ui/gfx/color_transform.cc:703:15 19:03:27.700 29717 #6 0x767f315 in GetColorSpace ui/gfx/icc_profile.cc:142:45 19:03:27.700 29717 #7 0xb2263ae in initializeLayerTreeView content/renderer/render_widget.cc:1141:61 19:03:27.700 29717 #8 0xb1e68fd in initializeLayerTreeView content/renderer/render_view_impl.cc:1956:17 19:03:27.700 29717 #9 0xc1c6b06 in initializeLayerTreeView third_party/WebKit/Source/web/WebViewImpl.cpp:4341:19 19:03:27.700 29717 #10 0xc1c57bf in WebViewImpl third_party/WebKit/Source/web/WebViewImpl.cpp:471:5 19:03:27.700 29717 #11 0xc1c29ff in create third_party/WebKit/Source/web/WebViewImpl.cpp:342:25 19:03:27.700 29717 #12 0xc1c29ff in create third_party/WebKit/Source/web/WebViewImpl.cpp:336:0 19:03:27.700 29717 #13 0xb19b457 in Initialize content/renderer/render_view_impl.cc:717:7 <snip> Original issue's description: > cc: Plumb the monitor color profile to renderer for rasterization > > This adds the output device color profile to display::Display, and > populates it correctly on Mac. We will want to do this for all > platforms. > > The color profile is then plumbed through the same IPCs that take > the device scale factor, to get to the renderer process' > RenderWidgetCompositor. > > Note that we are sending the full ICCProfile this far. This is > important, because the renderer process will be setting the ICCProfile > of its rasterized IOSurfaces, and there is a power impact of even slight > differences between the monitor profile and the IOSurface profile. > > The ICCProfile is then sent as a gfx::ColorProfile (which internally > references the ICCProfile, for the above purpose) to the > RenderWidgetCompositor, from where it will be pushed to cc. > > In the next step, we will (under a flag) specify the color space > for rasterization. > > BUG=44872 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/f1fef7489c29deeee2a29c41ce4851e9ad1bd67b > Cr-Commit-Position: refs/heads/master@{#418422} TBR=enne@chromium.org,clamy@chromium.org,dcheng@chromium.org,ellyjones@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=44872 Committed: https://crrev.com/72cc58add8718a0093e160aa96341ba887144cc3 Cr-Commit-Position: refs/heads/master@{#418490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -71 lines) Patch
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +7 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/screen_info.h View 1 chunk +1 line, -10 lines 0 comments Download
M content/public/common/screen_info.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/display/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/display/android/screen_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/display.h View 3 chunks +0 lines, -19 lines 0 comments Download
M ui/display/display.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/display/mac/screen_mac.mm View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yuta Kitamura
Created Revert of cc: Plumb the monitor color profile to renderer for rasterization
4 years, 3 months ago (2016-09-14 05:04:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336113003/1
4 years, 3 months ago (2016-09-14 05:04:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 05:05:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72cc58add8718a0093e160aa96341ba887144cc3 Cr-Commit-Position: refs/heads/master@{#418490}
4 years, 3 months ago (2016-09-14 05:07:08 UTC) #7
ccameron
On 2016/09/14 05:07:08, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 3 months ago (2016-09-14 07:31:22 UTC) #8
Yuta Kitamura
4 years, 3 months ago (2016-09-14 09:05:16 UTC) #9
Message was sent while issue was closed.
On 2016/09/14 07:31:22, ccameron wrote:
> On 2016/09/14 05:07:08, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/72cc58add8718a0093e160aa96341ba887144cc3
> > Cr-Commit-Position: refs/heads/master@{#418490}
> 
> Thank you!
> 
> I believe I have fixed the uninitialized read in
> https://codereview.chromium.org/2337423002/

Feel free to reland this, then :)

Powered by Google App Engine
This is Rietveld 408576698