Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1782)

Unified Diff: chrome/browser/notifications/notification_ui_manager.cc

Issue 23361031: [Mac] Delete old balloon and Notification Center notification implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix DCHECK Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager.cc
diff --git a/chrome/browser/notifications/notification_ui_manager.cc b/chrome/browser/notifications/notification_ui_manager.cc
index 19e6c242d0ba1d99fff69808727fa782338d515e..d6c0f0f0aa33b36b932c0918bf5bf5f991615e1b 100644
--- a/chrome/browser/notifications/notification_ui_manager.cc
+++ b/chrome/browser/notifications/notification_ui_manager.cc
@@ -25,7 +25,6 @@ bool NotificationUIManager::DelegatesToMessageCenter() {
return message_center::IsRichNotificationEnabled();
}
-#if !defined(OS_MACOSX)
// static
NotificationUIManager* NotificationUIManager::Create(PrefService* local_state) {
if (DelegatesToMessageCenter()) {
@@ -39,9 +38,13 @@ NotificationUIManager* NotificationUIManager::Create(PrefService* local_state) {
settings_provider.Pass());
}
+#if defined(OS_MACOSX)
+ NOTREACHED();
+ return NULL;
+#else
BalloonNotificationUIManager* balloon_manager =
new BalloonNotificationUIManager(local_state);
balloon_manager->SetBalloonCollection(BalloonCollection::Create());
return balloon_manager;
-}
#endif
+}

Powered by Google App Engine
This is Rietveld 408576698