chrome/browser/notifications/message_center_notifications_browsertest.cc - Issue 23361031: [Mac] Delete old balloon and Notification Center notification implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 23361031: [Mac] Delete old balloon and Notification Center notification implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix DCHECK Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notifications_unittest.cc ('k') | chrome/browser/notifications/notification_ui_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notifications_browsertest.cc

diff --git a/chrome/browser/notifications/message_center_notifications_browsertest.cc b/chrome/browser/notifications/message_center_notifications_browsertest.cc

index 84cde473fc6c8155b202e0c4229992adfa9e59c1..0213ec193481fd0ee652410399013a1700fa0d3d 100644

--- a/chrome/browser/notifications/message_center_notifications_browsertest.cc

+++ b/chrome/browser/notifications/message_center_notifications_browsertest.cc

@@ -150,10 +150,6 @@ class MessageCenterNotificationsTest : public InProcessBrowserTest {

}

};

-// TODO(rsesek): Implement Message Center on Mac and get these tests passing

-// for real. http://crbug.com/179904

-#if !defined(OS_MACOSX)

IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest, RetrieveBaseParts) {

// Make sure comamnd-line switch has an effect.

EXPECT_EQ(NotificationUIManager::DelegatesToMessageCenter(),

@@ -412,7 +408,8 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,

delegate->Release();

}

-#if !defined(OS_CHROMEOS) && defined(RUN_MESSAGE_CENTER_TESTS)

+#if !defined(OS_CHROMEOS) && !defined(OS_MACOSX) && \

+ defined(RUN_MESSAGE_CENTER_TESTS)

#define MAYBE_HideWhenFullscreenEnabled HideWhenFullscreenEnabled

#else

#define MAYBE_HideWhenFullscreenEnabled DISABLED_HideWhenFullscreenEnabled

@@ -436,5 +433,3 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,

content::Details<bool>(&is_fullscreen));

EXPECT_FALSE(message_center()->HasPopupNotifications());

}

-#endif // !defined(OS_MACOSX)