Issue 23361031: [Mac] Delete old balloon and Notification Center notification implementations.

Issue 23361031: [Mac] Delete old balloon and Notification Center notification implementations. (Closed)

Created:
7 years, 3 months ago by Robert Sesek

Modified:
6 years, 8 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Delete old balloon and Notification Center notification implementations. This also makes message_center the one and only option for notifications. BUG=237150

Patch Set 1 #

Patch Set 2 : Test hackery #

Patch Set 3 : More fixes #

Patch Set 4 : Fix win7_aura #

Patch Set 5 : Fix DCHECK #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -1880 lines)			Patch
D	chrome/app/nibs/Notification.xib	View		1 chunk	+0 lines, -555 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.h	View	1 2 3 4	4 chunks	+30 lines, -9 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.cc	View	1 2 3 4	17 chunks	+122 lines, -53 lines	0 comments	Download
M	chrome/browser/notifications/message_center_notifications_browsertest.cc	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/notifications/notification_ui_manager.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
D	chrome/browser/notifications/notification_ui_manager_mac.h	View		1 chunk	+0 lines, -87 lines	0 comments	Download
D	chrome/browser/notifications/notification_ui_manager_mac.mm	View		1 chunk	+0 lines, -346 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm	View		1 chunk	+0 lines, -79 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_controller.h	View		1 chunk	+0 lines, -94 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_controller.mm	View		1 chunk	+0 lines, -224 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm	View		1 chunk	+0 lines, -116 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_view.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_view.mm	View		1 chunk	+0 lines, -100 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_view_bridge.h	View		1 chunk	+0 lines, -39 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_view_bridge.mm	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.h	View		1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3 4	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/chrome_nibs.gyp	View	1 2 3 4	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_nibs.gypi	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/message_center/message_center_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

7 years, 3 months ago (2013-08-26 15:05:06 UTC) #2

Hm. I guess this won't work because of interactive_ui_tests
chrome/browser/notifications/desktop_notifications_unittest.cc. Those seem to
test the DesktopNotificationService but are dependent on the Balloon-based
implementation :/

Expand Messages | Collapse Messages