Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 23361030: Smaller instruction to test negative number on ia32 (Closed)

Created:
7 years, 3 months ago by weiliang.lin2
Modified:
7 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Smaller instruction to test negative number on ia32 BUG= R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/ia32/disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
weiliang.lin2
7 years, 3 months ago (2013-08-26 13:28:18 UTC) #1
Jakob Kummerow
LGTM, I'll land.
7 years, 3 months ago (2013-08-26 13:58:27 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-08-26 16:48:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698