src/ia32/disasm-ia32.cc - Issue 23361030: Smaller instruction to test negative number on ia32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/disasm-ia32.cc

Issue 23361030: Smaller instruction to test negative number on ia32 (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/disasm-ia32.cc

diff --git a/src/ia32/disasm-ia32.cc b/src/ia32/disasm-ia32.cc

index 892b66e814a5b6e82cabf1029db5f7ec013edf46..293d42832ee1d0b4e3b94ff3d651d2a8aa86f49a 100644

--- a/src/ia32/disasm-ia32.cc

+++ b/src/ia32/disasm-ia32.cc

@@ -606,7 +606,7 @@ int DisassemblerIA32::D1D3C1Instruction(byte* data) {

}

ASSERT_NE(NULL, mnem);

AppendToBuffer("%s %s,", mnem, NameOfCPURegister(rm));

- if (imm8 > 0) {

+ if (imm8 >= 0) {

AppendToBuffer("%d", imm8);

} else {

AppendToBuffer("cl");

« no previous file with comments | « no previous file | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »