Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: components/domain_reliability/uploader.h

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: Remove outdated comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/service.cc ('k') | components/domain_reliability/uploader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/uploader.h
diff --git a/components/domain_reliability/uploader.h b/components/domain_reliability/uploader.h
index 6962711ce1b1cf62596d7caa0cdcd7d319e3c6cc..c72148f3dfe1fe846a114b2d4ea81fed4758d6ae 100644
--- a/components/domain_reliability/uploader.h
+++ b/components/domain_reliability/uploader.h
@@ -65,6 +65,11 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityUploader {
const GURL& upload_url,
const UploadCallback& callback) = 0;
+ // Shuts down the uploader prior to destruction. Currently, terminates pending
+ // uploads and prevents the uploader from starting new ones to avoid hairy
+ // lifetime issues at destruction.
+ virtual void Shutdown();
+
virtual void set_discard_uploads(bool discard_uploads) = 0;
static int GetURLRequestUploadDepth(const net::URLRequest& request);
« no previous file with comments | « components/domain_reliability/service.cc ('k') | components/domain_reliability/uploader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698