Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: components/domain_reliability/service.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: Remove outdated comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/service.h ('k') | components/domain_reliability/uploader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/service.cc
diff --git a/components/domain_reliability/service.cc b/components/domain_reliability/service.cc
index cdc91d7dc27edf1943860699c37b4d36b1a19739..92eec4238d2b0cd58d10104d2ae26172b02f3f43 100644
--- a/components/domain_reliability/service.cc
+++ b/components/domain_reliability/service.cc
@@ -18,6 +18,15 @@ namespace domain_reliability {
namespace {
+void AddContextForTestingOnNetworkTaskRunner(
+ base::WeakPtr<DomainReliabilityMonitor> monitor,
+ std::unique_ptr<const DomainReliabilityConfig> config) {
+ if (!monitor)
+ return;
+
+ monitor->AddContextForTesting(std::move(config));
+}
+
std::unique_ptr<base::Value> GetWebUIDataOnNetworkTaskRunner(
base::WeakPtr<DomainReliabilityMonitor> monitor) {
if (!monitor) {
@@ -83,6 +92,36 @@ class DomainReliabilityServiceImpl : public DomainReliabilityService {
callback);
}
+ void SetDiscardUploadsForTesting(bool discard_uploads) override {
+ DCHECK(network_task_runner_.get());
+
+ network_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&DomainReliabilityMonitor::SetDiscardUploads,
+ monitor_,
+ discard_uploads));
+ }
+
+ void AddContextForTesting(
+ std::unique_ptr<const DomainReliabilityConfig> config) override {
+ DCHECK(network_task_runner_.get());
+
+ network_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&AddContextForTestingOnNetworkTaskRunner,
+ monitor_,
+ base::Passed(&config)));
+ }
+
+ void ForceUploadsForTesting() override {
+ DCHECK(network_task_runner_.get());
+
+ network_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&DomainReliabilityMonitor::ForceUploadsForTesting,
+ monitor_));
+ }
+
private:
std::string upload_reporter_string_;
base::WeakPtr<DomainReliabilityMonitor> monitor_;
« no previous file with comments | « components/domain_reliability/service.h ('k') | components/domain_reliability/uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698