Domain Reliability: Don't crash on shutdown with uploads pending

components/domain_reliability/dispatcher.cc

Index: components/domain_reliability/dispatcher.cc
diff --git a/components/domain_reliability/dispatcher.cc b/components/domain_reliability/dispatcher.cc
index 3abef20e77747ce2ec1e389c6716d3689d18c38b..c4efdd00dcccbb9c9c5904227ff71e69cfa01a22 100644
--- a/components/domain_reliability/dispatcher.cc
+++ b/components/domain_reliability/dispatcher.cc
@@ -83,6 +83,17 @@ void DomainReliabilityDispatcher::RunEligibleTasks() {
   }
 }
 
+void DomainReliabilityDispatcher::RunAllTasksForTesting() {
+  std::set<Task*> tasks;
+  for (auto& task : tasks_)
+    tasks.insert(task.get());

[mmenke, 2016/12/14 19:12:17]

std::set<Task*> tasks = tasks_;?

[Julia Tuttle, 2016/12/15 21:53:00]

Doesn't work; tasks_ contains unique_ptr<Task> while tasks contains Task*.

+
+  for (auto* task : tasks) {
+    DCHECK(task);
+    RunAndDeleteTask(task);
+  }

[mmenke, 2016/12/14 19:12:17]

I assume we can't just do:

while(!tasks.empty()) {...}

because running one task may add another?  If that's the case, worth mentioning
this magic in the header?  Not clear what it does and does not run.

If that's not the case, suggest switching.

[Julia Tuttle, 2016/12/15 21:53:00]

Yeah, same contract as RunEligibleTasks -- it runs only tasks that existed when
it was called. I'll document that.

+}
+
 void DomainReliabilityDispatcher::MakeTaskWaiting(Task* task) {
   DCHECK(task);
   DCHECK(!task->eligible);