Domain Reliability: Don't crash on shutdown with uploads pending

components/domain_reliability/dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/dispatcher.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 65 matching lines @@
   std::set<Task*> tasks;
   tasks.swap(eligible_tasks_);
 
   for (auto* task : tasks) {
     DCHECK(task);
     DCHECK(task->eligible);
     RunAndDeleteTask(task);
   }
 }
 
+void DomainReliabilityDispatcher::RunAllTasksForTesting() {
+  std::set<Task*> tasks;
+  for (auto& task : tasks_)
+    tasks.insert(task.get());

[mmenke, 2016/12/14 19:12:17]

std::set<Task*> tasks = tasks_;?

[Julia Tuttle, 2016/12/15 21:53:00]

Doesn't work; tasks_ contains unique_ptr<Task> while tasks contains Task*.

+
+  for (auto* task : tasks) {
+    DCHECK(task);
+    RunAndDeleteTask(task);
+  }

[mmenke, 2016/12/14 19:12:17]

I assume we can't just do:

while(!tasks.empty()) {...}

because running one task may add another?  If that's the case, worth mentioning
this magic in the header?  Not clear what it does and does not run.

If that's not the case, suggest switching.

[Julia Tuttle, 2016/12/15 21:53:00]

Yeah, same contract as RunEligibleTasks -- it runs only tasks that existed when
it was called. I'll document that.

+}
+
 void DomainReliabilityDispatcher::MakeTaskWaiting(Task* task) {
   DCHECK(task);
   DCHECK(!task->eligible);
   DCHECK(!task->timer->IsRunning());
   task->timer->Start(FROM_HERE,
                      task->min_delay,
                      base::Bind(&DomainReliabilityDispatcher::MakeTaskEligible,
                                 base::Unretained(this),
                                 task));
 }
@@ skipping 21 matching lines @@
   auto it = std::find_if(tasks_.begin(), tasks_.end(),
                          [task](const std::unique_ptr<Task>& task_ptr) {
                            return task_ptr.get() == task;
                          });
 
   DCHECK(it != tasks_.end());
   tasks_.erase(it);
 }
 
 }  // namespace domain_reliability