Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2335993003: gyp: Move shim_headers.gypi from chromium. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
brettw, chromium-reviews
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

gyp: Move shim_headers.gypi from chromium. The file was removed in chromium: https://codereview.chromium.org/2331893004 This moves it here to keep the logic working for projects depending on ICU that still have a few gyp bots. BUG=chromium:474921 R=jochen@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/b0bd3ee50bc2e768d7a17cbc60d87f517f024dbe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2 lines) Patch
M icu.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A shim_headers.gypi View 1 chunk +60 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2335993003/diff/1/shim_headers.gypi File shim_headers.gypi (right): https://codereview.chromium.org/2335993003/diff/1/shim_headers.gypi#newcode1 shim_headers.gypi:1: # Copyright (c) 2012 The Chromium Authors. All ...
4 years, 3 months ago (2016-09-13 07:04:15 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-13 13:53:07 UTC) #4
Michael Achenbach
4 years, 3 months ago (2016-09-13 13:59:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0bd3ee50bc2e768d7a17cbc60d87f517f024dbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698