Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 2331893004: Remove GYP files in breakpad, build, and tools. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, Dan Beam
CC:
chromium-reviews, tfarina, scheib+watch_chromium.org, mikecase+watch_chromium.org, fuzzing_chromium.org, jbudorick+watch_chromium.org, jshin+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GYP files in breakpad, build, and tools. These are now unused. Committed: https://crrev.com/8c0eb8ed764590108f0278e5bbbddec3fc14b522 Cr-Commit-Position: refs/heads/master@{#418010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19649 lines) Patch
D breakpad/breakpad.gyp View 1 chunk +0 lines, -954 lines 0 comments Download
D breakpad/breakpad_handler.gypi View 1 chunk +0 lines, -87 lines 0 comments Download
D breakpad/breakpad_sender.gypi View 1 chunk +0 lines, -67 lines 0 comments Download
D breakpad/breakpad_tools.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
D build/all.gyp View 1 chunk +0 lines, -1342 lines 0 comments Download
D build/android/android_lint_cache.gyp View 1 chunk +0 lines, -51 lines 0 comments Download
D build/android/apkbuilder_action.gypi View 1 chunk +0 lines, -84 lines 0 comments Download
D build/android/copy_ex.gypi View 1 chunk +0 lines, -79 lines 0 comments Download
D build/android/create_standalone_apk_action.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D build/android/developer_recommended_flags.gypi View 1 chunk +0 lines, -61 lines 0 comments Download
D build/android/dex_action.gypi View 1 chunk +0 lines, -63 lines 0 comments Download
D build/android/disable_gcc_lto.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
D build/android/emma_instr_action.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
D build/android/finalize_apk_action.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D build/android/finalize_splits_action.gypi View 1 chunk +0 lines, -76 lines 0 comments Download
D build/android/increase_size_for_speed.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D build/android/insert_chromium_version.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
D build/android/java_cpp_enum.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
D build/android/java_cpp_template.gypi View 1 chunk +0 lines, -81 lines 0 comments Download
D build/android/java_google_api_keys.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
D build/android/jinja_template.gypi View 1 chunk +0 lines, -85 lines 0 comments Download
D build/android/lint_action.gypi View 1 chunk +0 lines, -51 lines 0 comments Download
D build/android/locale_pak_resources.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
D build/android/main_dex_action.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
D build/android/native_app_dependencies.gypi View 1 chunk +0 lines, -76 lines 0 comments Download
D build/android/ndk.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D build/android/pack_relocations.gypi View 1 chunk +0 lines, -77 lines 0 comments Download
D build/android/package_resources_action.gypi View 1 chunk +0 lines, -105 lines 0 comments Download
D build/android/push_libraries.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D build/android/pylib/device/commands/commands.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
D build/android/pylib/remote/device/dummy/dummy.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
D build/android/rezip.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D build/android/setup.gyp View 1 chunk +0 lines, -112 lines 0 comments Download
D build/android/strip_native_libraries.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
D build/android/test_runner.gypi View 1 chunk +0 lines, -107 lines 0 comments Download
D build/android/v8_external_startup_data_arch_suffix.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
D build/android/write_ordered_libraries.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D build/apk_browsertest.gypi View 1 chunk +0 lines, -44 lines 0 comments Download
D build/apk_fake_jar.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D build/apk_test.gypi View 1 chunk +0 lines, -83 lines 0 comments Download
D build/buildflag_header.gypi View 1 chunk +0 lines, -123 lines 0 comments Download
D build/chrome_settings.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
D build/common.gypi View 1 chunk +0 lines, -6348 lines 0 comments Download
D build/common_untrusted.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
D build/copy_test_data_ios.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D build/filename_rules.gypi View 1 chunk +0 lines, -102 lines 0 comments Download
D build/gn_migration.gypi View 1 chunk +0 lines, -763 lines 0 comments Download
D build/grit_action.gypi View 1 chunk +0 lines, -71 lines 0 comments Download
D build/grit_target.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D build/host_jar.gypi View 1 chunk +0 lines, -149 lines 0 comments Download
D build/host_prebuilt_jar.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D build/internal/release_defaults.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
D build/internal/release_impl.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
D build/internal/release_impl_official.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D build/ios/coverage.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
D build/isolate.gypi View 1 chunk +0 lines, -129 lines 0 comments Download
D build/jar_file_jni_generator.gypi View 1 chunk +0 lines, -72 lines 0 comments Download
D build/java.gypi View 1 chunk +0 lines, -398 lines 0 comments Download
D build/java_aidl.gypi View 1 chunk +0 lines, -79 lines 0 comments Download
D build/java_apk.gypi View 1 chunk +0 lines, -1242 lines 0 comments Download
D build/java_prebuilt.gypi View 1 chunk +0 lines, -101 lines 0 comments Download
D build/java_strings_grd.gypi View 1 chunk +0 lines, -62 lines 0 comments Download
D build/jni_generator.gypi View 1 chunk +0 lines, -77 lines 0 comments Download
D build/json_schema_bundle_compile.gypi View 1 chunk +0 lines, -88 lines 0 comments Download
D build/json_schema_bundle_registration_compile.gypi View 1 chunk +0 lines, -83 lines 0 comments Download
D build/json_schema_compile.gypi View 1 chunk +0 lines, -123 lines 0 comments Download
D build/json_to_struct.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
D build/linux/system.gyp View 1 chunk +0 lines, -1270 lines 0 comments Download
D build/linux/unbundle/expat.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D build/linux/unbundle/ffmpeg.gyp View 1 chunk +0 lines, -65 lines 0 comments Download
D build/linux/unbundle/flac.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D build/linux/unbundle/harfbuzz.gyp View 1 chunk +0 lines, -47 lines 0 comments Download
D build/linux/unbundle/icu.gyp View 1 chunk +0 lines, -248 lines 0 comments Download
D build/linux/unbundle/jsoncpp.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D build/linux/unbundle/libXNVCtrl.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D build/linux/unbundle/libevent.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D build/linux/unbundle/libjpeg.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D build/linux/unbundle/libpng.gyp View 1 chunk +0 lines, -38 lines 0 comments Download
D build/linux/unbundle/libusb.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D build/linux/unbundle/libvpx.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
D build/linux/unbundle/libwebp.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
D build/linux/unbundle/libxml.gyp View 1 chunk +0 lines, -38 lines 0 comments Download
D build/linux/unbundle/libxslt.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D build/linux/unbundle/opus.gyp View 1 chunk +0 lines, -38 lines 0 comments Download
D build/linux/unbundle/protobuf.gyp View 1 chunk +0 lines, -149 lines 0 comments Download
D build/linux/unbundle/re2.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D build/linux/unbundle/snappy.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D build/linux/unbundle/sqlite.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
D build/linux/unbundle/v8.gyp View 1 chunk +0 lines, -64 lines 0 comments Download
D build/linux/unbundle/zlib.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
D build/mac/asan.gyp View 1 chunk +0 lines, -53 lines 0 comments Download
D build/nocompile.gypi View 1 chunk +0 lines, -97 lines 0 comments Download
D build/protoc.gypi View 1 chunk +0 lines, -164 lines 0 comments Download
D build/protoc_java.gypi View 1 chunk +0 lines, -83 lines 0 comments Download
D build/release.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
D build/repack_action.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D build/sanitizers/sanitizers.gyp View 1 chunk +0 lines, -93 lines 0 comments Download
D build/set_clang_warning_flags.gypi View 1 chunk +0 lines, -58 lines 0 comments Download
D build/shim_headers.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
D build/some.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D build/util/version.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
D build/win/asan.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
D build/win_precompile.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/android/adb_reboot/adb_reboot.gyp View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/android/android_tools.gyp View 1 chunk +0 lines, -88 lines 0 comments Download
D tools/android/audio_focus_grabber/audio_focus_grabber.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/android/common/common.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/android/customtabs_benchmark/customtabs_benchmark.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/android/file_poller/file_poller.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D tools/android/findbugs_plugin/findbugs_plugin.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/android/forwarder/forwarder.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/android/forwarder2/forwarder.gyp View 1 chunk +0 lines, -77 lines 0 comments Download
D tools/android/kerberos/kerberos.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/android/md5sum/md5sum.gyp View 1 chunk +0 lines, -81 lines 0 comments Download
D tools/android/memconsumer/memconsumer.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/android/memdump/memdump.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/android/memtrack_helper/memtrack_helper.gyp View 1 chunk +0 lines, -61 lines 0 comments Download
D tools/android/ps_ext/ps_ext.gyp View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/android/purge_ashmem/purge_ashmem.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/android/push_apps_to_background/push_apps_to_background.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/battor_agent/battor_agent.gyp View 1 chunk +0 lines, -93 lines 0 comments Download
D tools/cygprofile/cygprofile.gyp View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/gn/gn.gyp View 1 chunk +0 lines, -330 lines 0 comments Download
D tools/imagediff/image_diff.gyp View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/ipc_fuzzer/fuzzer/fuzzer.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
D tools/ipc_fuzzer/ipc_fuzzer.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/ipc_fuzzer/message_dump/message_dump.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/ipc_fuzzer/message_lib/message_lib.gyp View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/ipc_fuzzer/message_replay/message_replay.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/ipc_fuzzer/message_tools/message_tools.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/json_schema_compiler/api_gen_util.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/json_schema_compiler/json_features.gypi View 1 chunk +0 lines, -63 lines 0 comments Download
D tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 1 chunk +0 lines, -66 lines 0 comments Download
D tools/perf/clear_system_cache/clear_system_cache.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/usb_gadget/usb_gadget.gyp View 1 chunk +0 lines, -55 lines 0 comments Download
D tools/win/static_initializers/static_initializers.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/xdisplaycheck/xdisplaycheck.gyp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
brettw
4 years, 3 months ago (2016-09-12 18:22:46 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-12 18:24:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331893004/1
4 years, 3 months ago (2016-09-12 19:46:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 19:53:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8c0eb8ed764590108f0278e5bbbddec3fc14b522 Cr-Commit-Position: refs/heads/master@{#418010}
4 years, 3 months ago (2016-09-12 19:55:37 UTC) #12
Dan Beam
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/69584 I have no idea why or why we'd be using build/common.gypi, but I'll look
4 years, 3 months ago (2016-09-12 20:33:20 UTC) #14
Dirk Pranke
On 2016/09/12 20:33:20, Dan Beam wrote: > https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/69584 > > I have no idea why ...
4 years, 3 months ago (2016-09-12 20:58:59 UTC) #15
Dan Beam
On 2016/09/12 20:58:59, Dirk Pranke wrote: > On 2016/09/12 20:33:20, Dan Beam wrote: > > ...
4 years, 3 months ago (2016-09-12 21:14:34 UTC) #16
Dirk Pranke
4 years, 3 months ago (2016-09-12 21:17:07 UTC) #17
Message was sent while issue was closed.
On 2016/09/12 21:14:34, Dan Beam wrote:
> On 2016/09/12 20:58:59, Dirk Pranke wrote:
> > On 2016/09/12 20:33:20, Dan Beam wrote:
> > >
> >
>
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...
> > > 
> > > I have no idea why or why we'd be using build/common.gypi, but I'll look
> > 
> > build/gyp_chromium.py unconditionally includes build/common.gypi, for
> starters.
> 
> ah. we could move to tools/gyp/gyp again, but that's also going to be removed.
> 
> can you guys just help unblock us moving to GN instead of removing GYP? 
brettw@
> voiced objections on using GN for this system over email (or at least asked us
> if it was the right tool), but the thread hasn't been updated since last
> Thursday afternoon.

I'm planning on looking at this starting today (was on vacation for past week
and a half).

I'll see if I can un-break gyp_chromium for now.

Powered by Google App Engine
This is Rietveld 408576698