Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Issue 2335933002: Subzero: x8664: Fix a "uitofp i32 to double" lowering error. (Closed)

Created:
4 years, 3 months ago by Jim Stichnoth
Modified:
4 years, 3 months ago
Reviewers:
John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: x8664: Fix a "uitofp i32 to double" lowering error. The movzx instruction in the lowering sequence should not be allowed to be elided. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4379 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=74bfa8712543f32b75bbeb0ab0d43ec599d02059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
John - does this look right? Can you think of other _movzx() that should also ...
4 years, 3 months ago (2016-09-12 23:39:34 UTC) #3
John
lgtm
4 years, 3 months ago (2016-09-13 00:08:36 UTC) #4
Jim Stichnoth
4 years, 3 months ago (2016-09-13 02:11:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74bfa8712543f32b75bbeb0ab0d43ec599d02059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698