Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2335713002: [Extensions] Add metrics for renderer sync IPCs performance (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add metrics for renderer sync IPCs performance In the renderer, extensions use sync IPCs to request port ids and request the i18n message bundle. We're looking into fixing this, but it'll be useful to know how much time it's taking now. BUG=645261 Review-Url: https://codereview.chromium.org/2316093004 Cr-Commit-Position: refs/heads/master@{#417489} (cherry picked from commit 11a07f288fe1590b41452214f16d1777706046b9) Committed: https://chromium.googlesource.com/chromium/src/+/5b31379bc1607d5edbb8bcc15256527322849121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -11 lines) Patch
M chrome/renderer/extensions/tabs_custom_bindings.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M extensions/renderer/i18n_custom_bindings.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 3 months ago (2016-09-12 16:47:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b31379bc1607d5edbb8bcc15256527322849121.

Powered by Google App Engine
This is Rietveld 408576698