[Extensions] Add metrics for renderer sync IPCs performance

[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261
Committed: https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9
Cr-Commit-Position: refs/heads/master@{#417489}

[Devlin, 2016-09-08 21:27:12]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:27:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-09-08 22:03:50]

Description was changed from

==========
metrics

BUG=
==========

to

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=642380
==========

[Devlin, 2016-09-08 22:05:00]

Description was changed from

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=642380
==========

to

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261
==========

[Devlin, 2016-09-08 22:05:58]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org, mpearson@chromium.org

[Devlin, 2016-09-08 22:05:59]

Istiaque, mind taking a look?  I'd like to land this first and see if we can
merge back to m54 to get some fun metrics.
Mark, can you check the histograms?

[lazyboy, 2016-09-08 22:27:24]

lgtm

[Mark P, 2016-09-08 22:48:53]

histograms.xml lgtm with one comment

https://codereview.chromium.org/2316093004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2316093004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:15865: +    extension message port id
from the browser.
nit: given that the function you're call in all these cases for this histogram
(and suffix friends) is ExtensionHostMsg_OpenChannelTo..., perhaps this
description should mention the word "channel" somewhere.  Maybe also the
histogram name should be revised.

[commit-bot: I haz the power, 2016-09-08 22:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:56:14]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-08 23:04:03]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[Devlin, 2016-09-08 23:04:22]

https://codereview.chromium.org/2316093004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2316093004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:15865: +    extension message port id
from the browser.
On 2016/09/08 22:48:53, Mark P wrote:
> nit: given that the function you're call in all these cases for this histogram
> (and suffix friends) is ExtensionHostMsg_OpenChannelTo..., perhaps this
> description should mention the word "channel" somewhere.  Maybe also the
> histogram name should be revised.

Adjusted the histogram description.  I think the name's probably okay, since
Port is the (slightly) more canonical reference to this, but let me know if you
disagree and I'll update it.

[commit-bot: I haz the power, 2016-09-08 23:04:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:14:20]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Mark P, 2016-09-08 23:27:59]

lgtm

[Devlin, 2016-09-09 00:13:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-09-09 00:13:27]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2316093004/#ps20001
(title: "Mark's")

[commit-bot: I haz the power, 2016-09-09 00:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:18:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-09-09 00:37:13]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:38:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:46:23]

Exceeded global retry quota

[Devlin, 2016-09-09 02:19:15]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-09 02:19:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 03:10:36]

Description was changed from

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261
==========

to

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261
==========

[commit-bot: I haz the power, 2016-09-09 03:10:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 03:13:43]

Description was changed from

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261
==========

to

==========
[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261

Committed: https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9
Cr-Commit-Position: refs/heads/master@{#417489}
==========

[commit-bot: I haz the power, 2016-09-09 03:13:44]

Patchset 2 (id:??) landed as
https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9
Cr-Commit-Position: refs/heads/master@{#417489}