Use sk_sp-based text blob APIs

Use sk_sp-based text blob APIs

Convert text blob building & drawing to sk_sp-based APIs.

Also deconstify the blob type to reduce friction, and remove unused
PassTextBlobPtr.

R=jbroman@chromium.org,reed@google.com

Committed: https://crrev.com/b483c9abec96a1eb92e9d59bcfc279788bdec37e
Cr-Commit-Position: refs/heads/master@{#418259}

[f(malita), 2016-09-12 16:25:02]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 16:25:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-12 16:50:54]

https://codereview.chromium.org/2335703002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/text/TextRun.h (right):

https://codereview.chromium.org/2335703002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/text/TextRun.h:253: sk_sp<SkTextBlob>*
cachedTextBlob;
Is this really tri-state w/ meaning?

- null ptr
- ptr to null textblob
- ptr to textblob
?

[f(malita), 2016-09-12 17:18:18]

https://codereview.chromium.org/2335703002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/text/TextRun.h (right):

https://codereview.chromium.org/2335703002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/text/TextRun.h:253: sk_sp<SkTextBlob>*
cachedTextBlob;
On 2016/09/12 16:50:54, reed1 wrote:
> Is this really tri-state w/ meaning?
> 
> - null ptr
> - ptr to null textblob
> - ptr to textblob
> ?

It's an out-param:

> - null ptr

the caller cannot/will not cache this blob

> - ptr to null textblob

the result blob is uncacheable

> - ptr to textblob

a cacheable/cached blob


I suspect this could be refactored to always return a cacheable blob and then
let the caller drop it on the floor if needed, maybe we can look at that
separately.

[commit-bot: I haz the power, 2016-09-12 18:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:33:34]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-13 15:43:49]

lgtm

[f(malita), 2016-09-13 15:46:42]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-09-13 15:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 15:52:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-13 15:55:18]

Description was changed from

==========
Use sk_sp-based text blob APIs

Convert text blob building & drawing to sk_sp-based APIs.

Also deconstify the blob type to reduce friction, and remove unused
PassTextBlobPtr.

R=jbroman@chromium.org,reed@google.com
==========

to

==========
Use sk_sp-based text blob APIs

Convert text blob building & drawing to sk_sp-based APIs.

Also deconstify the blob type to reduce friction, and remove unused
PassTextBlobPtr.

R=jbroman@chromium.org,reed@google.com

Committed: https://crrev.com/b483c9abec96a1eb92e9d59bcfc279788bdec37e
Cr-Commit-Position: refs/heads/master@{#418259}
==========

[commit-bot: I haz the power, 2016-09-13 15:55:20]

Patchset 1 (id:??) landed as
https://crrev.com/b483c9abec96a1eb92e9d59bcfc279788bdec37e
Cr-Commit-Position: refs/heads/master@{#418259}