third_party/WebKit/Source/platform/text/TextRun.h - Issue 2335703002: Use sk_sp-based text blob APIs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/text/TextRun.h

Issue 2335703002: Use sk_sp-based text blob APIs (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Antti Koivisto (koivisto@kde.org)	3 * (C) 2000 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2003, 2006, 2007, 2011 Apple Inc. All rights reserved.	5 * Copyright (C) 2003, 2006, 2007, 2011 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 232 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
243 , from(0)	243 , from(0)

244 , to(r.length())	244 , to(r.length())

245 , cachedTextBlob(nullptr)	245 , cachedTextBlob(nullptr)

246 {	246 {

247 }	247 }

248	248

249 const TextRun& run;	249 const TextRun& run;

250 unsigned from;	250 unsigned from;

251 unsigned to;	251 unsigned to;

252 FloatRect bounds;	252 FloatRect bounds;

253 sk_sp<const SkTextBlob>* cachedTextBlob;	253 sk_sp<SkTextBlob>* cachedTextBlob;
	reed1 2016/09/12 16:50:54 Is this really tri-state w/ meaning? - null ptr - Is this really tri-state w/ meaning? - null ptr - ptr to null textblob - ptr to textblob ? f(malita) 2016/09/12 17:18:18 It's an out-param: Show quoted text On 2016/09/12 16:50:54, reed1 wrote: > Is this really tri-state w/ meaning? > > - null ptr > - ptr to null textblob > - ptr to textblob > ? It's an out-param: Show quoted text > - null ptr the caller cannot/will not cache this blob Show quoted text > - ptr to null textblob the result blob is uncacheable Show quoted text > - ptr to textblob a cacheable/cached blob I suspect this could be refactored to always return a cacheable blob and then let the caller drop it on the floor if needed, maybe we can look at that separately.
254 };	254 };

255	255

256 } // namespace blink	256 } // namespace blink

257 #endif	257 #endif

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/TextBlob.h ('k') | no next file » | no next file with comments »