Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2335693002: Add support for accessing field formal parameters in the initializer list of constructors (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, eernst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for accessing field formal parameters in the initializer list of constructors R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a5ee525e14d7a8c920c818c1e938ac079d3c3b2b

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -22 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 5 chunks +45 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 3 chunks +24 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 1 chunk +19 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-12 15:18:53 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-12 15:38:20 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-12 16:48:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a5ee525e14d7a8c920c818c1e938ac079d3c3b2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698