chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc - Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm ('K') | « chrome/browser/ui/views/website_settings/permission_prompt_impl.cc ('k') | chrome/browser/ui/website_settings/mock_permission_prompt_factory.h » ('j') | chrome/browser/ui/website_settings/mock_permission_prompt_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

index fd06d0ec3a5a83a5941d99888a23cd5e1bc1b8fa..8e21b396fee26895a856d7df12863ab8a2017369 100644

--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

@@ -48,6 +48,7 @@ views::BubbleBorder::Arrow PermissionPromptImpl::GetAnchorArrow() {

}

// static

-std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(Browser* browser) {

- return base::WrapUnique(new PermissionPromptImpl(browser));

+std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(

+ content::WebContents* web_contents) {

+ return base::WrapUnique(new PermissionPromptImpl(web_contents));

}