Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3207)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
index 00d89a43ae35e70fac31c720ddc0d983bdacde8b..402d730aeaa9244969b0316a65dfe5390f449197 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/platform_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
#include "chrome/browser/ui/views/website_settings/permission_selector_row.h"
@@ -20,6 +21,7 @@
#include "chrome/grit/generated_resources.h"
#include "components/strings/grit/components_strings.h"
#include "components/url_formatter/elide_url.h"
+#include "content/public/browser/web_contents.h"
#include "ui/accessibility/ax_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/combobox_model.h"
@@ -373,12 +375,12 @@ void PermissionsBubbleDialogDelegateView::UpdateAnchor(
//////////////////////////////////////////////////////////////////////////////
// PermissionPromptImpl
-PermissionPromptImpl::PermissionPromptImpl(Browser* browser)
- : browser_(browser),
+PermissionPromptImpl::PermissionPromptImpl(content::WebContents* web_contents)
+ : browser_(chrome::FindBrowserWithWebContents(web_contents)),
delegate_(nullptr),
bubble_delegate_(nullptr) {
- DCHECK(browser);
- DCHECK(browser->window());
+ DCHECK(browser_);
+ DCHECK(browser_->window());
}
PermissionPromptImpl::~PermissionPromptImpl() {

Powered by Google App Engine
This is Rietveld 408576698