Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2335583003: Update tests. (Closed)

Created:
4 years, 3 months ago by floitsch
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), sigurdm
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update tests. Tests were testing the output of the async/await transformation which got a fix in 0683f819793e6f11e72dcdbd15ba0855c8af03f (https://codereview.chromium.org/2322323002 ),not passing an unnecessary additional argument. Fixes #27295. R=sigurdm@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/899891e5c5cedc2ad06f62e3be7f6d60f43de3e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M tests/compiler/dart2js/async_await_js_transform_test.dart View 14 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
floitsch
4 years, 3 months ago (2016-09-12 11:46:41 UTC) #4
sigurdm
LGTM
4 years, 3 months ago (2016-09-12 12:17:37 UTC) #6
Bill Hesse
lgtm
4 years, 3 months ago (2016-09-12 12:18:23 UTC) #7
floitsch
Committed patchset #1 (id:1) manually as 899891e5c5cedc2ad06f62e3be7f6d60f43de3e7 (presubmit successful).
4 years, 3 months ago (2016-09-12 13:10:01 UTC) #10
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-12 16:08:41 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698