Async-helper only takes 3 arguments.

Async-helper only takes 3 arguments.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0683f819793e6f11e72dcdbd15ba0855c8af03f4

[floitsch, 2016-09-09 15:40:35]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-09-09 19:45:14]

lgtm - I missing some context here, should we add some tests that provide
coverage for this?

[floitsch, 2016-09-10 11:09:57]

On 2016/09/09 19:45:14, Siggi Cherem (dart-lang) wrote:
> lgtm - I missing some context here, should we add some tests that provide
> coverage for this?

I doubt we can do this.
These are JS calls (we generate) where the additional argument was just silently
swallowed.
There (hopefully) won't be any semantic difference in the execution. Maybe (with
a bit of luck) the JS engines will just be a bit faster, since they don't need
to go through their internal stubs (and even here I doubt that we will be able
to measure any difference).

[floitsch, 2016-09-10 11:10:40]

Description was changed from

==========
Async-helper only takes 3 arguments.
==========

to

==========
Async-helper only takes 3 arguments.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0683f819793e6f11e72dcdbd15ba0855c8af03f4
==========

[floitsch, 2016-09-10 11:10:41]

Committed patchset #1 (id:1) manually as
0683f819793e6f11e72dcdbd15ba0855c8af03f4 (presubmit successful).