Update new tab button even when not visible

Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682
Committed: https://crrev.com/1293941bc65cfd82fcc6cb4866831750e1ca744e
Cr-Commit-Position: refs/heads/master@{#418741}

[mdjones, 2016-09-14 23:55:19]

Description was changed from

==========
Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. In these cases the new tab button still
needs to be updated.

BUG=642682
==========

to

==========
Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682
==========

[mdjones, 2016-09-14 23:55:52]

mdjones@chromium.org changed reviewers:
+ tedchoc@chromium.org

[mdjones, 2016-09-14 23:55:52]

ptal

[Ted C, 2016-09-15 00:09:27]

lgtm

[mdjones, 2016-09-15 00:28:04]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:28:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 01:15:27]

Description was changed from

==========
Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682
==========

to

==========
Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682
==========

[commit-bot: I haz the power, 2016-09-15 01:15:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 01:18:13]

Description was changed from

==========
Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682
==========

to

==========
Update new tab button even when not visible

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682

Committed: https://crrev.com/1293941bc65cfd82fcc6cb4866831750e1ca744e
Cr-Commit-Position: refs/heads/master@{#418741}
==========

[commit-bot: I haz the power, 2016-09-15 01:18:14]

Patchset 1 (id:??) landed as
https://crrev.com/1293941bc65cfd82fcc6cb4866831750e1ca744e
Cr-Commit-Position: refs/heads/master@{#418741}