chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java - Issue 2335403004: Update new tab button even when not visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 2335403004: Update new tab button even when not visible (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

index fedc894ca0c60b55048b343ff0b6e5b525743eed..c10141438b561cc3b62993b3efdf2474e297e589 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

@@ -2154,7 +2154,7 @@ public class ToolbarPhone extends ToolbarLayout

updateNtpTransitionAnimation();

}

- if (inOrEnteringTabSwitcher) mNewTabButton.setIsIncognito(isIncognito);

+ mNewTabButton.setIsIncognito(isIncognito);

CharSequence newTabContentDescription = getResources().getText(

isIncognito ? R.string.accessibility_toolbar_btn_new_incognito_tab :

« no previous file with comments | « no previous file | no next file » | no next file with comments »