Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2335373002: Desktop Capture Picker: More Clear Selection [M54] (Closed)

Created:
4 years, 3 months ago by qiangchen
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Desktop Capture Picker: More Clear Selection We set border color for source item to indicate it is selected. But the color is just light grey on Windows and ChromeOS, and thus hardly visible. We changed to use kColorId_FocusedBorderColor, which looks good on all platforms. BUG=643292 TBR=msw@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2323913002 Cr-Commit-Position: refs/heads/master@{#417964} (cherry picked from commit 4b2cc3e651652b3bab2ed52c33488ebad57731e4)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc View 5 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335373002/1
4 years, 3 months ago (2016-09-13 20:57:04 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/branch-heads/2840'. nothing ...
4 years, 3 months ago (2016-09-13 21:02:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335373002/1
4 years, 3 months ago (2016-09-13 21:39:12 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 21:42:16 UTC) #9
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/branch-heads/2840'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698