Desktop Capture Picker: More Clear Selection

Desktop Capture Picker: More Clear Selection

We set border color for source item to indicate it is selected.
But the color is just light grey on Windows and ChromeOS, and thus
hardly visible.

We changed to use kColorId_FocusedBorderColor, which looks good
on all platforms.

BUG=643292
Committed: https://crrev.com/4b2cc3e651652b3bab2ed52c33488ebad57731e4
Cr-Commit-Position: refs/heads/master@{#417964}

[qiangchen, 2016-09-09 17:37:05]

Patchset #1 (id:1) has been deleted

[qiangchen, 2016-09-09 17:42:00]

Description was changed from

==========
Desktop Capture Picker: More Clear Selection

BUG=643292
==========

to

==========
Desktop Capture Picker: More Clear Selection

We set border color for source item to indicate it is selected.
But the color is just light grey on Windows and ChromeOS, and thus
hardly visible.

We changed to use kColorId_FocusedBorderColor, which looks good
on all platforms.

BUG=643292
==========

[qiangchen, 2016-09-09 17:42:00]

qiangchen@chromium.org changed reviewers:
+ msw@chromium.org

[qiangchen, 2016-09-09 17:45:23]

After some investigation, I chose kColorId_FocusedBorderColor, as the MDTab uses
this color to represent selection. So it is safe to use and will be consistent
with the container considering the upcoming MD implementation of TabbedPane.

And I have tested across the platforms making sure they look good.

Thanks.

[msw, 2016-09-10 00:07:41]

nice; lgtm with a nit.

https://codereview.chromium.org/2323913002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
(right):

https://codereview.chromium.org/2323913002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc:13:
#include "ui/views/background.h"
nit: remove

[qiangchen, 2016-09-12 16:30:47]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2016-09-12 16:30:47]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2323913002/#ps40001
(title: "Remove include")

[commit-bot: I haz the power, 2016-09-12 16:31:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qiangchen, 2016-09-12 16:49:56]

https://codereview.chromium.org/2323913002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
(right):

https://codereview.chromium.org/2323913002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc:13:
#include "ui/views/background.h"
On 2016/09/10 00:07:41, msw wrote:
> nit: remove

Done.

[commit-bot: I haz the power, 2016-09-12 17:21:57]

Description was changed from

==========
Desktop Capture Picker: More Clear Selection

We set border color for source item to indicate it is selected.
But the color is just light grey on Windows and ChromeOS, and thus
hardly visible.

We changed to use kColorId_FocusedBorderColor, which looks good
on all platforms.

BUG=643292
==========

to

==========
Desktop Capture Picker: More Clear Selection

We set border color for source item to indicate it is selected.
But the color is just light grey on Windows and ChromeOS, and thus
hardly visible.

We changed to use kColorId_FocusedBorderColor, which looks good
on all platforms.

BUG=643292
==========

[commit-bot: I haz the power, 2016-09-12 17:21:58]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-12 17:23:44]

Description was changed from

==========
Desktop Capture Picker: More Clear Selection

We set border color for source item to indicate it is selected.
But the color is just light grey on Windows and ChromeOS, and thus
hardly visible.

We changed to use kColorId_FocusedBorderColor, which looks good
on all platforms.

BUG=643292
==========

to

==========
Desktop Capture Picker: More Clear Selection

We set border color for source item to indicate it is selected.
But the color is just light grey on Windows and ChromeOS, and thus
hardly visible.

We changed to use kColorId_FocusedBorderColor, which looks good
on all platforms.

BUG=643292

Committed: https://crrev.com/4b2cc3e651652b3bab2ed52c33488ebad57731e4
Cr-Commit-Position: refs/heads/master@{#417964}
==========

[commit-bot: I haz the power, 2016-09-12 17:23:45]

Patchset 2 (id:??) landed as
https://crrev.com/4b2cc3e651652b3bab2ed52c33488ebad57731e4
Cr-Commit-Position: refs/heads/master@{#417964}