Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Unified Diff: chrome/browser/ui/views/intent_picker_bubble_view.h

Issue 2335313003: Refactor IntentPickerBubbleView::ShowBubble() (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/intent_picker_bubble_view.h
diff --git a/chrome/browser/ui/views/intent_picker_bubble_view.h b/chrome/browser/ui/views/intent_picker_bubble_view.h
index 36c0f475f94c0085f10cffd50f0c631aa88b11f2..a44bcedad50a1931c19ca06f8577e16aaa73586e 100644
--- a/chrome/browser/ui/views/intent_picker_bubble_view.h
+++ b/chrome/browser/ui/views/intent_picker_bubble_view.h
@@ -17,7 +17,6 @@
#include "ui/views/controls/button/button.h"
namespace content {
-class NavigationHandle;
class WebContents;
} // namespace content
@@ -61,7 +60,7 @@ class IntentPickerBubbleView : public views::BubbleDialogDelegateView,
base::Callback<void(size_t, arc::ArcNavigationThrottle::CloseReason)>;
~IntentPickerBubbleView() override;
- static void ShowBubble(content::NavigationHandle* handle,
+ static void ShowBubble(content::WebContents* contents,
djacobo_ 2016/09/14 17:16:56 nit: same here, let's go either |contents| or |web
Yusuke Sato 2016/09/14 18:15:55 Done.
const std::vector<NameAndIcon>& app_info,
const ThrottleCallback& throttle_cb);
static std::unique_ptr<IntentPickerBubbleView> CreateBubbleView(

Powered by Google App Engine
This is Rietveld 408576698