Refactor IntentPickerBubbleView::ShowBubble()

chrome/browser/ui/views/intent_picker_bubble_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_INTENT_PICKER_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_INTENT_PICKER_BUBBLE_VIEW_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/bubble/bubble_dialog_delegate.h"
 #include "ui/views/controls/button/button.h"
 
 namespace content {
-class NavigationHandle;
 class WebContents;
 }  // namespace content
 
 namespace views {
 class Label;
 class LabelButton;
 class View;
 class Widget;
 }  // namespace views
 
@@ skipping 23 matching lines @@
   using NameAndIcon = arc::ArcNavigationThrottle::NameAndIcon;
   // This callback informs the index of the app selected by the user, along with
   // the reason why the Bubble was closed. The size_t param must have a value in
   // the range [0, app_info.size()-1], except when the CloseReason is ERROR or
   // DIALOG_DEACTIVATED, for these cases we return a dummy value
   // |kAppTagNoneSelected| which won't be used at all and has no significance.
   using ThrottleCallback =
       base::Callback<void(size_t, arc::ArcNavigationThrottle::CloseReason)>;
 
   ~IntentPickerBubbleView() override;
-  static void ShowBubble(content::NavigationHandle* handle,
+  static void ShowBubble(content::WebContents* contents,

[djacobo_, 2016/09/14 17:16:56]

nit: same here, let's go either |contents| or |web_contents| in all the class.

[Yusuke Sato, 2016/09/14 18:15:55]

Done.

                          const std::vector<NameAndIcon>& app_info,
                          const ThrottleCallback& throttle_cb);
   static std::unique_ptr<IntentPickerBubbleView> CreateBubbleView(
       const std::vector<NameAndIcon>& app_info,
       const ThrottleCallback& throttle_cb,
       content::WebContents* web_contents);
 
  protected:
   // views::BubbleDialogDelegateView overrides:
   void Init() override;
@@ skipping 38 matching lines @@
   views::LabelButton* always_button_;
   views::LabelButton* just_once_button_;
   views::ScrollView* scroll_view_;
 
   std::vector<NameAndIcon> app_info_;
 
   DISALLOW_COPY_AND_ASSIGN(IntentPickerBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_INTENT_PICKER_BUBBLE_VIEW_H_