Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2335213004: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, yamaguchi+watch_chromium.org, oka+watch_chromium.org, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some ChromeSyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - feedback_private - file_manager/private_api_drive - file_manager/private_api_misc - file_manager/private_api_strings - file_manager/private_api_tasks - file_system - file_system_provider BUG=634140 Committed: https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9 Cr-Commit-Position: refs/heads/master@{#418613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -170 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.h View 9 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 8 chunks +42 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 4 chunks +30 lines, -31 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.h View 4 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 5 chunks +22 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
Antony, mind taking a look?
4 years, 3 months ago (2016-09-14 16:20:26 UTC) #7
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-09-14 17:20:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335213004/1
4 years, 3 months ago (2016-09-14 18:11:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 18:18:59 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:22:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9
Cr-Commit-Position: refs/heads/master@{#418613}

Powered by Google App Engine
This is Rietveld 408576698