Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2707)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2335213004: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index d94ac07371de32793bdc3378fd071feae5621a6d..58a93349b3c26eb23468e6823cb59745ade7045b 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -153,7 +153,7 @@ void FeedbackPrivateAPI::RequestFeedbackForFlow(
// static
base::Closure* FeedbackPrivateGetStringsFunction::test_callback_ = NULL;
-bool FeedbackPrivateGetStringsFunction::RunSync() {
+ExtensionFunction::ResponseAction FeedbackPrivateGetStringsFunction::Run() {
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
#define SET_STRING(id, idr) \
@@ -204,21 +204,19 @@ bool FeedbackPrivateGetStringsFunction::RunSync() {
const std::string& app_locale = g_browser_process->GetApplicationLocale();
webui::SetLoadTimeDataDefaults(app_locale, dict.get());
- SetResult(std::move(dict));
if (test_callback_ && !test_callback_->is_null())
test_callback_->Run();
- return true;
+ return RespondNow(OneArgument(std::move(dict)));
}
-bool FeedbackPrivateGetUserEmailFunction::RunSync() {
- SigninManagerBase* signin_manager =
- SigninManagerFactory::GetForProfile(GetProfile());
- SetResult(base::MakeUnique<base::StringValue>(
+ExtensionFunction::ResponseAction FeedbackPrivateGetUserEmailFunction::Run() {
+ SigninManagerBase* signin_manager = SigninManagerFactory::GetForProfile(
+ Profile::FromBrowserContext(browser_context()));
+ return RespondNow(OneArgument(base::MakeUnique<base::StringValue>(
signin_manager ? signin_manager->GetAuthenticatedAccountInfo().email
- : std::string()));
- return true;
+ : std::string())));
}
bool FeedbackPrivateGetSystemInformationFunction::RunAsync() {

Powered by Google App Engine
This is Rietveld 408576698