Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document). (Closed)
Patch Set: Fix nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp b/third_party/WebKit/Source/bindings/templates/interface_base.cpp
index 8db5c296f763822485e2178e83a1d55402d53692..23383d9d3e6063e67defcb2b88a5ba03d2587452 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp
@@ -96,6 +96,7 @@ static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallba
attribute_getter, attribute_getter_callback,
attribute_setter, attribute_setter_callback,
attribute_getter_builder_callback,
+ attribute_surrogate_property_callback,
attribute_getter_implemented_in_private_script,
attribute_setter_implemented_in_private_script
with context %}
@@ -103,6 +104,9 @@ static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallba
{% if attribute.has_fast_accessor %}
{{attribute_getter_builder_callback(attribute)}}
{% endif %}
+{% if attribute.is_store_in_field %}
+{{attribute_surrogate_property_callback(attribute)}}
+{% endif %}
{% for world_suffix in attribute.world_suffixes %}
{% if not attribute.has_custom_getter and not attribute.constructor_type %}
{{attribute_getter(attribute, world_suffix)}}

Powered by Google App Engine
This is Rietveld 408576698