third_party/WebKit/Source/bindings/templates/interface_base.cpp - Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document).

Side by Side Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document). (Closed)

Patch Set: Fix nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/Source/bindings/scripts/v8_interface.py ('K') | « third_party/WebKit/Source/bindings/templates/interface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {% filter format_blink_cpp_source_code %}	1 {% filter format_blink_cpp_source_code %}

2	2

3 {% include 'copyright_block.txt' %}	3 {% include 'copyright_block.txt' %}

4 #include "{{v8_class_or_partial}}.h"	4 #include "{{v8_class_or_partial}}.h"

5	5

6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}	6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}

7 #include "{{filename}}"	7 #include "{{filename}}"

8 {% endfor %}	8 {% endfor %}

9	9

10 namespace blink {	10 namespace blink {

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 with context %}	89 with context %}

90 {% for constant in constants \| has_special_getter %}	90 {% for constant in constants \| has_special_getter %}

91 {{constant_getter_callback(constant)}}	91 {{constant_getter_callback(constant)}}

92 {% endfor %}	92 {% endfor %}

93 {# Attributes #}	93 {# Attributes #}

94 {##############################################################################}	94 {##############################################################################}

95 {% from 'attributes.cpp' import constructor_getter_callback,	95 {% from 'attributes.cpp' import constructor_getter_callback,

96 attribute_getter, attribute_getter_callback,	96 attribute_getter, attribute_getter_callback,

97 attribute_setter, attribute_setter_callback,	97 attribute_setter, attribute_setter_callback,

98 attribute_getter_builder_callback,	98 attribute_getter_builder_callback,

	99 attribute_surrogate_property_callback,

99 attribute_getter_implemented_in_private_script,	100 attribute_getter_implemented_in_private_script,

100 attribute_setter_implemented_in_private_script	101 attribute_setter_implemented_in_private_script

101 with context %}	102 with context %}

102 {% for attribute in attributes if attribute.should_be_exposed_to_script %}	103 {% for attribute in attributes if attribute.should_be_exposed_to_script %}

103 {% if attribute.has_fast_accessor %}	104 {% if attribute.has_fast_accessor %}

104 {{attribute_getter_builder_callback(attribute)}}	105 {{attribute_getter_builder_callback(attribute)}}

105 {% endif %}	106 {% endif %}

	107 {% if attribute.is_store_in_field %}

	108 {{attribute_surrogate_property_callback(attribute)}}

	109 {% endif %}

106 {% for world_suffix in attribute.world_suffixes %}	110 {% for world_suffix in attribute.world_suffixes %}

107 {% if not attribute.has_custom_getter and not attribute.constructor_type %}	111 {% if not attribute.has_custom_getter and not attribute.constructor_type %}

108 {{attribute_getter(attribute, world_suffix)}}	112 {{attribute_getter(attribute, world_suffix)}}

109 {% endif %}	113 {% endif %}

110 {% if not attribute.constructor_type %}	114 {% if not attribute.constructor_type %}

111 {{attribute_getter_callback(attribute, world_suffix)}}	115 {{attribute_getter_callback(attribute, world_suffix)}}

112 {% elif attribute.needs_constructor_getter_callback %}	116 {% elif attribute.needs_constructor_getter_callback %}

113 {{constructor_getter_callback(attribute, world_suffix)}}	117 {{constructor_getter_callback(attribute, world_suffix)}}

114 {% endif %}	118 {% endif %}

115 {% if attribute.has_setter %}	119 {% if attribute.has_setter %}

(...skipping 345 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
461 {% for attribute in attributes if attribute.is_implemented_in_private_script %}	465 {% for attribute in attributes if attribute.is_implemented_in_private_script %}

462 {{attribute_getter_implemented_in_private_script(attribute)}}	466 {{attribute_getter_implemented_in_private_script(attribute)}}

463 {% if attribute.has_setter %}	467 {% if attribute.has_setter %}

464 {{attribute_setter_implemented_in_private_script(attribute)}}	468 {{attribute_setter_implemented_in_private_script(attribute)}}

465 {% endif %}	469 {% endif %}

466 {% endfor %}	470 {% endfor %}

467 {% block partial_interface %}{% endblock %}	471 {% block partial_interface %}{% endblock %}

468 } // namespace blink	472 } // namespace blink

469	473

470 {% endfilter %}{# format_blink_cpp_source_code #}	474 {% endfilter %}{# format_blink_cpp_source_code #}

OLD	NEW