third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document). (Closed)

Patch Set: Fix nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index a8b70905c090b87faa4160b7ed00f0b1f853dff6..38f9bafa1c2974af9ce4154d19ce5b894fb1b6c4 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -62,6 +62,7 @@ INTERFACE_CPP_INCLUDES = frozenset([

'bindings/core/v8/GeneratedCodeHelper.h',

'bindings/core/v8/V8DOMConfiguration.h',

'bindings/core/v8/V8ObjectConstructor.h',

+ 'bindings/core/v8/V8PrivateProperty.h',

Yuki 2016/09/20 07:53:53 nit: It's better to include the header iff you rea

Alfonso 2016/09/20 13:48:23 Could you indicate me where to add the include pro

Yuki 2016/09/20 13:57:19 https://cs.chromium.org/chromium/src/third_party/W

'core/dom/Document.h',

'wtf/GetPtr.h',

'wtf/RefPtr.h',