Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document). (Closed)
Patch Set: Fix nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # coding=utf-8 2 # coding=utf-8
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 'bindings/core/v8/V8Binding.h', 55 'bindings/core/v8/V8Binding.h',
56 'bindings/core/v8/V8DOMWrapper.h', 56 'bindings/core/v8/V8DOMWrapper.h',
57 'bindings/core/v8/WrapperTypeInfo.h', 57 'bindings/core/v8/WrapperTypeInfo.h',
58 'platform/heap/Handle.h', 58 'platform/heap/Handle.h',
59 ]) 59 ])
60 INTERFACE_CPP_INCLUDES = frozenset([ 60 INTERFACE_CPP_INCLUDES = frozenset([
61 'bindings/core/v8/ExceptionState.h', 61 'bindings/core/v8/ExceptionState.h',
62 'bindings/core/v8/GeneratedCodeHelper.h', 62 'bindings/core/v8/GeneratedCodeHelper.h',
63 'bindings/core/v8/V8DOMConfiguration.h', 63 'bindings/core/v8/V8DOMConfiguration.h',
64 'bindings/core/v8/V8ObjectConstructor.h', 64 'bindings/core/v8/V8ObjectConstructor.h',
65 'bindings/core/v8/V8PrivateProperty.h',
Yuki 2016/09/20 07:53:53 nit: It's better to include the header iff you rea
Alfonso 2016/09/20 13:48:23 Could you indicate me where to add the include pro
Yuki 2016/09/20 13:57:19 https://cs.chromium.org/chromium/src/third_party/W
65 'core/dom/Document.h', 66 'core/dom/Document.h',
66 'wtf/GetPtr.h', 67 'wtf/GetPtr.h',
67 'wtf/RefPtr.h', 68 'wtf/RefPtr.h',
68 ]) 69 ])
69 70
70 71
71 def filter_has_constant_configuration(constants): 72 def filter_has_constant_configuration(constants):
72 return [constant for constant in constants if 73 return [constant for constant in constants if
73 not constant['measure_as'] and 74 not constant['measure_as'] and
74 not constant['deprecate_as'] and 75 not constant['deprecate_as'] and
(...skipping 1329 matching lines...) Expand 10 before | Expand all | Expand 10 after
1404 extended_attributes = deleter.extended_attributes 1405 extended_attributes = deleter.extended_attributes
1405 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState') 1406 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState')
1406 is_ce_reactions = 'CEReactions' in extended_attributes 1407 is_ce_reactions = 'CEReactions' in extended_attributes
1407 return { 1408 return {
1408 'is_call_with_script_state': is_call_with_script_state, 1409 'is_call_with_script_state': is_call_with_script_state,
1409 'is_ce_reactions': is_ce_reactions, 1410 'is_ce_reactions': is_ce_reactions,
1410 'is_custom': 'Custom' in extended_attributes, 1411 'is_custom': 'Custom' in extended_attributes,
1411 'is_raises_exception': 'RaisesException' in extended_attributes, 1412 'is_raises_exception': 'RaisesException' in extended_attributes,
1412 'name': cpp_name(deleter), 1413 'name': cpp_name(deleter),
1413 } 1414 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698