Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2335133005: Make WebSocket people per-file OWNERS of net/socket for files starting with "websocket" (Closed)

Created:
4 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebSocket people per-file OWNERS of net/socket for files starting with "websocket" R=mmenke@chromium.org BUG=none Committed: https://crrev.com/3a00cb3814f26705029307ff96db48ef036a0183 Cr-Commit-Position: refs/heads/master@{#418538}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A net/socket/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tyoshino (SeeGerritForStatus)
4 years, 3 months ago (2016-09-14 07:39:17 UTC) #3
mmenke
LGTM, modulo comment https://codereview.chromium.org/2335133005/diff/1/net/socket/OWNERS File net/socket/OWNERS (right): https://codereview.chromium.org/2335133005/diff/1/net/socket/OWNERS#newcode2 net/socket/OWNERS:2: per-file websocket.*=file://net/websockets/OWNERS I think this should ...
4 years, 3 months ago (2016-09-14 08:47:06 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/2335133005/diff/1/net/socket/OWNERS File net/socket/OWNERS (right): https://codereview.chromium.org/2335133005/diff/1/net/socket/OWNERS#newcode2 net/socket/OWNERS:2: per-file websocket.*=file://net/websockets/OWNERS On 2016/09/14 08:47:06, mmenke wrote: > I ...
4 years, 3 months ago (2016-09-14 11:38:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335133005/20001
4 years, 3 months ago (2016-09-14 11:40:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 12:32:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:34:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a00cb3814f26705029307ff96db48ef036a0183
Cr-Commit-Position: refs/heads/master@{#418538}

Powered by Google App Engine
This is Rietveld 408576698