net/socket/OWNERS - Issue 2335133005: Make WebSocket people per-file OWNERS of net/socket for files starting with "websocket"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/socket/OWNERS

Issue 2335133005: Make WebSocket people per-file OWNERS of net/socket for files starting with "websocket" (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # WebSocket

	2 per-file websocket.*=file://net/websockets/OWNERS
	mmenke 2016/09/14 08:47:06 I think this should be: per-file websocket* (Or we I think this should be: per-file websocket* (Or websocket_) Just look at other per-file regexps: https://cs.chromium.org/search/?q=per-file.%5C&sq=package:chromium&type=cs tyoshino (SeeGerritForStatus)* 2016/09/14 11:38:37 Oh, right. I copied an existing one, but looks it' Show quoted text On 2016/09/14 08:47:06, mmenke wrote: > I think this should be: per-file websocket* (Or websocket_) > > Just look at other per-file regexps: > https://cs.chromium.org/search/?q=per-file.%5C*&sq=package:chromium&type=cs Oh, right. I copied an existing one, but looks it's just wrong and there's no longer any file starting with websocket... Fixed.
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »