Issue 233503002: gyp: avoid copying items that will be deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233503002: gyp: avoid copying items that will be deleted. (Closed)

Created:
6 years, 8 months ago by Daniel Bratell

Modified:
6 years, 8 months ago

Reviewers:
Mark Mentovai, Nico

CC:
gyp-developer_googlegroups.com, scottmg

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Visibility:
Public.

More Reviews

Description

gyp: avoid copying items that will be deleted. We spent a few CPU seconds copying items we deleted a few lines further down. Seems a bit wasteful. This saves around 0.5 real world seconds for me. BUG=362075 R=mark@chromium.org r1904

Patch Set 1 #

Patch Set 2 : dontcopybeforedelete: Rebased to newer master #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -17 lines)			Patch
	M	pylib/gyp/input.py	View	1	1 chunk	+8 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Daniel Bratell

Ah, this was where I started. By noticing that we first copied and then deleted ...

6 years, 8 months ago (2014-04-10 16:41:43 UTC) #1

Message was sent while issue was closed.

r1904

Expand Messages | Collapse Messages