SkRecordDraw: use SkCanvas::quickRejectY for text draws

SkRecordDraw: use SkCanvas::quickRejectY for text draws

 PS 1) factor apart into canSkip, draw, updateClip
 PS 2) use quickRejectY for text


BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14192

[mtklein, 2014-04-14 16:30:35]

Tested this by profiling tabl_mozilla.skp with a 512x512 tile before and after. 
Runs ~10x faster, and drawPosText and drawPosTextH drop _way_ down on the
profile as expected.

[tomhudson, 2014-04-14 17:12:16]

https://codereview.chromium.org/233493004/diff/20001/src/record/SkRecordDraw.cpp
File src/record/SkRecordDraw.cpp (right):

https://codereview.chromium.org/233493004/diff/20001/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:68: // We can skip these commands only if they're
intersecting an empty clip.
What does it mean for a clip to intersect the empty clip?

Or am I confusing an empty clip (no clip has been set, draw everything) with the
empty clip (clip everything away, draw nothing)? Is there a better name for
fClipEmpty?

[mtklein, 2014-04-14 18:08:16]

https://codereview.chromium.org/233493004/diff/20001/src/record/SkRecordDraw.cpp
File src/record/SkRecordDraw.cpp (right):

https://codereview.chromium.org/233493004/diff/20001/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:68: // We can skip these commands only if they're
intersecting an empty clip.
On 2014/04/14 17:12:16, tomhudson wrote:
> What does it mean for a clip to intersect the empty clip?
> 
> Or am I confusing an empty clip (no clip has been set, draw everything) with
the
> empty clip (clip everything away, draw nothing)? Is there a better name for
> fClipEmpty?

This is clip-everything-away-draw-nothing empty clip.  I think the older comment
was clearer.  Let me put that back.

[reed1, 2014-04-14 19:10:18]

lgtm

[mtklein, 2014-04-14 19:26:51]

lgtm

[commit-bot: I haz the power, 2014-04-14 19:27:02]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/233493004/40001

[commit-bot: I haz the power, 2014-04-14 20:35:13]

Change committed as 14192