Verify value of prec before using

Verify value of prec before using

The fx_codec_jpx_opj code will attempt to do a 1 << (prec - 1). If the prec
value is >=32 then that shift will overflow the int value. This CL adds a check
that prec is < 32 before attempting the shift.

BUG=chromium:633208
Committed: https://pdfium.googlesource.com/pdfium/+/db319ec6a9330e75276b873f6027caddf2a15ec0

[dsinclair, 2016-09-12 18:33:03]

dsinclair@chromium.org changed reviewers:
+ ochang@chromium.org, tsepez@chromium.org

[dsinclair, 2016-09-12 18:33:04]

PTAL.

[dsinclair, 2016-09-12 18:33:17]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 18:33:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-12 18:37:36]

https://codereview.chromium.org/2334823002/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec_jpx_opj.cpp (right):

https://codereview.chromium.org/2334823002/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec_jpx_opj.cpp:234: if (prec >= 32)
what if its < 0 ?

[commit-bot: I haz the power, 2016-09-12 18:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:53:36]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-12 19:46:59]

https://codereview.chromium.org/2334823002/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec_jpx_opj.cpp (right):

https://codereview.chromium.org/2334823002/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec_jpx_opj.cpp:234: if (prec >= 32)
On 2016/09/12 18:37:36, Tom Sepez wrote:
> what if its < 0 ?

Done. Checked for <= 0 as we do prec - 1 below.

[Tom Sepez, 2016-09-12 20:42:46]

lgtm

[dsinclair, 2016-09-12 20:47:07]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-09-12 20:47:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:04:10]

Description was changed from

==========
Verify value of prec before using

The fx_codec_jpx_opj code will attempt to do a 1 << (prec - 1). If the prec
value is >=32 then that shift will overflow the int value. This CL adds a check
that prec is < 32 before attempting the shift.

BUG=chromium:633208
==========

to

==========
Verify value of prec before using

The fx_codec_jpx_opj code will attempt to do a 1 << (prec - 1). If the prec
value is >=32 then that shift will overflow the int value. This CL adds a check
that prec is < 32 before attempting the shift.

BUG=chromium:633208

Committed:
https://pdfium.googlesource.com/pdfium/+/db319ec6a9330e75276b873f6027caddf2a1...
==========

[commit-bot: I haz the power, 2016-09-12 21:04:11]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/db319ec6a9330e75276b873f6027caddf2a1...