core/fxcodec/codec/fx_codec_jpx_opj.cpp - Issue 2334823002: Verify value of prec before using

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/fx_codec_jpx_opj.cpp

Issue 2334823002: Verify value of prec before using (Closed)

Patch Set: review feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/codec/fx_codec_jpx_opj.cpp

diff --git a/core/fxcodec/codec/fx_codec_jpx_opj.cpp b/core/fxcodec/codec/fx_codec_jpx_opj.cpp

index ed9331974d68dba971336410310c6ebe71518272..a1c38d06e93629b1ce277e966a2bc0329987e71e 100644

--- a/core/fxcodec/codec/fx_codec_jpx_opj.cpp

+++ b/core/fxcodec/codec/fx_codec_jpx_opj.cpp

@@ -231,6 +231,9 @@ static void sycc422_to_rgb(opj_image_t* img) {

return;

int prec = img->comps[0].prec;

+ if (prec <= 0 || prec >= 32)

+ return;

int offset = 1 << (prec - 1);

int upb = (1 << prec) - 1;

« no previous file with comments | « no previous file | no next file » | no next file with comments »