Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2334693003:
Add ARIA markup for tabs & tab panels (Closed)
|
Created:
4 years, 3 months ago by hhillen Modified:
4 years, 3 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd ARIA markup for tabs & tab panels, make active tab part of the tab order
BUG=646099
Committed: https://crrev.com/044ed68383b84bb98ecb7985fc065e12dc84b084
Cr-Commit-Position: refs/heads/master@{#418700}
Patch Set 1 #
Total comments: 6
Patch Set 2 : fixed aboxhall comments #
Total comments: 2
Patch Set 3 : Remove roving tabindex per einbinder's suggestion #Patch Set 4 : forgot changing two aria-expanded attributes to aria-selected #
Messages
Total messages: 36 (21 generated)
hans.hillen@gmail.com changed reviewers: + aboxhall@chromium.org
The CQ bit was checked by hans.hillen@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add ARIA markup for tabs & tab panels bug=646099 ========== to ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order bug=646099 ==========
hans.hillen@gmail.com changed reviewers: + hans.hillen@gmail.com - Hans.Hillen@gmail.com
https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (right): https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:37: // change This probably isn't needed any more? https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:51: this._tabsElement.setAttribute("role", "presentation"); Is this so that the tabs end up being "direct" children of the tablist? If so, why not apply the tablist role/aria-label here? https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:775: tab.tabElement.setAttribute("aria-expanded", "true"); Should this be aria-selected per https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel ?
https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (right): https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:37: // change On 2016/09/12 20:41:11, aboxhall wrote: > This probably isn't needed any more? Done. https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:51: this._tabsElement.setAttribute("role", "presentation"); On 2016/09/12 20:41:11, aboxhall wrote: > Is this so that the tabs end up being "direct" children of the tablist? If so, > why not apply the tablist role/aria-label here? Good point, made the change https://codereview.chromium.org/2334693003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:775: tab.tabElement.setAttribute("aria-expanded", "true"); On 2016/09/12 20:41:11, aboxhall wrote: > Should this be aria-selected per > https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel ? Done.
Description was changed from ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order bug=646099 ========== to ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order BUG=646099 ==========
aboxhall@chromium.org changed reviewers: + einbinder@chromium.org - hans.hillen@gmail.com
lgtm +einbinder for devtools review
The CQ bit was checked by hans.hillen@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
einbinder@chromium.org changed reviewers: + hans.hillen@gmail.com - Hans.Hillen@gmail.com
lgtm https://codereview.chromium.org/2334693003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (right): https://codereview.chromium.org/2334693003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:774: tab.tabElement.tabIndex = 0; Let's move the tabIndex changes to the patch with the arrow key movement.
https://codereview.chromium.org/2334693003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (right): https://codereview.chromium.org/2334693003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:774: tab.tabElement.tabIndex = 0; On 2016/09/12 23:21:25, einbinder wrote: > Let's move the tabIndex changes to the patch with the arrow key movement. Done.
lgtm
The CQ bit was checked by hans.hillen@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from einbinder@chromium.org Link to the patchset: https://codereview.chromium.org/2334693003/#ps60001 (title: "forgot changing two aria-expanded attributes to aria-selected")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
hans.hillen@gmail.com changed reviewers: + dgozman@chromium.org, pfeldman@chromium.org
lgtm
The CQ bit was checked by hans.hillen@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order BUG=646099 ========== to ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order BUG=646099 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order BUG=646099 ========== to ========== Add ARIA markup for tabs & tab panels, make active tab part of the tab order BUG=646099 Committed: https://crrev.com/044ed68383b84bb98ecb7985fc065e12dc84b084 Cr-Commit-Position: refs/heads/master@{#418700} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/044ed68383b84bb98ecb7985fc065e12dc84b084 Cr-Commit-Position: refs/heads/master@{#418700} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
