third_party/WebKit/Source/devtools/front_end/ui/Panel.js - Issue 2334693003: Add ARIA markup for tabs & tab panels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Panel.js

Issue 2334693003: Add ARIA markup for tabs & tab panels (Closed)

Patch Set: forgot changing two aria-expanded attributes to aria-selected Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Panel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Panel.js b/third_party/WebKit/Source/devtools/front_end/ui/Panel.js

index ec8f0feb5757785e6292f235e952bdb796c8ada3..a9cf23fec12a490e05b35655587a5e2917d5d9ab 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Panel.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Panel.js

@@ -35,6 +35,8 @@ WebInspector.Panel = function(name)

WebInspector.VBox.call(this);

this.element.classList.add("panel");

+ this.element.setAttribute("role", "tabpanel");

+ this.element.setAttribute("aria-label", name);

this.element.classList.add(name);

this._panelName = name;

« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | no next file with comments »