Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 2334623003: Store net::ProxyServer in HttpResponseInfo object (Closed)
Patch Set: PS Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index 586f22247aeb33c99972112a74ff720050f10930..c025627e36637af367963e8c42c7a641149dd465 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -31,11 +31,13 @@
#include "content/public/common/process_type.h"
#include "content/public/common/resource_response.h"
#include "content/public/common/resource_type.h"
+#include "net/base/host_port_pair.h"
#include "net/base/io_buffer.h"
#include "net/base/load_flags.h"
#include "net/http/http_response_headers.h"
#include "net/nqe/effective_connection_type.h"
#include "net/nqe/network_quality_estimator.h"
+#include "net/proxy/proxy_server.h"
#include "net/ssl/client_cert_store.h"
#include "net/ssl/ssl_platform_key.h"
#include "net/ssl/ssl_private_key.h"
@@ -65,7 +67,11 @@ void PopulateResourceResponse(ResourceRequestInfoImpl* info,
response_info.npn_negotiated_protocol;
response->head.connection_info = response_info.connection_info;
response->head.was_fetched_via_proxy = request->was_fetched_via_proxy();
- response->head.proxy_server = response_info.proxy_server;
+ response->head.proxy_server =
+ !response_info.proxy_server.is_valid() ||
+ response_info.proxy_server.is_direct()
+ ? net::HostPortPair()
+ : response_info.proxy_server.host_port_pair();
response->head.socket_address = response_info.socket_address;
const content::ResourceRequestInfo* request_info =
content::ResourceRequestInfo::ForRequest(request);

Powered by Google App Engine
This is Rietveld 408576698