Store net::ProxyServer in HttpResponseInfo object

components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
index 30c3d25b04dbead6949c97757c8cd613a4449f5d..166685618eb5429bae00885e65126e4bae4bda48 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
@@ -340,18 +340,21 @@ bool DataReductionProxyConfig::WasDataReductionProxyUsed(
 }
 
 bool DataReductionProxyConfig::IsDataReductionProxy(
-    const net::HostPortPair& host_port_pair,
+    const net::ProxyServer& proxy_server,
     DataReductionProxyTypeInfo* proxy_info) const {
   DCHECK(thread_checker_.CalledOnValidThread());
 
+  if (!proxy_server.is_valid() || proxy_server.is_direct())

[Not at Google. Contact bengr, 2016/09/14 21:54:09]

Why is this test required now, when it wasn't before? Should they be DCHECKs
instead?

[tbansal1, 2016/09/14 22:04:16]

There are DCHECKS in net::PrxoyServer::host_port_pair() method that we want to
avoid tripping.
Conceptually, IsDataReductionProxy() takes any ProxyServer and returns
true/false based on if it is a DRP proxy or not. I do not think we should add
DCHECK to check if the passed proxy server is a valid non-direct proxy server.

+    return false;
+
   const std::vector<net::ProxyServer>& proxy_list =
       config_values_->proxies_for_http();
-  auto proxy_it =
-      std::find_if(proxy_list.begin(), proxy_list.end(),
-                   [&host_port_pair](const net::ProxyServer& proxy) {
-                     return proxy.is_valid() &&
-                            proxy.host_port_pair().Equals(host_port_pair);
-                   });
+  auto proxy_it = std::find_if(
+      proxy_list.begin(), proxy_list.end(),
+      [&proxy_server](const net::ProxyServer& proxy) {
+        return proxy.is_valid() &&
+               proxy.host_port_pair().Equals(proxy_server.host_port_pair());
+      });
 
   if (proxy_it != proxy_list.end()) {
     if (proxy_info) {
@@ -378,7 +381,7 @@ bool DataReductionProxyConfig::IsBypassedByDataReductionProxyLocalRules(
     return true;
   if (result.proxy_server().is_direct())
     return true;
-  return !IsDataReductionProxy(result.proxy_server().host_port_pair(), NULL);
+  return !IsDataReductionProxy(result.proxy_server(), NULL);
 }
 
 bool DataReductionProxyConfig::AreDataReductionProxiesBypassed(
@@ -423,7 +426,7 @@ bool DataReductionProxyConfig::AreProxiesBypassed(
       continue;
 
     base::TimeDelta delay;
-    if (IsDataReductionProxy(proxy.host_port_pair(), NULL)) {
+    if (IsDataReductionProxy(proxy, NULL)) {
       if (!IsProxyBypassed(retry_map, proxy, &delay))
         return false;
       if (delay < min_delay)
@@ -590,7 +593,7 @@ bool DataReductionProxyConfig::ContainsDataReductionProxy(
       proxy_rules.MapUrlSchemeToProxyList("http");
   if (http_proxy_list && !http_proxy_list->IsEmpty() &&
       // Sufficient to check only the first proxy.
-      IsDataReductionProxy(http_proxy_list->Get().host_port_pair(), NULL)) {
+      IsDataReductionProxy(http_proxy_list->Get(), NULL)) {
     return true;
   }