chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

index e613f2665f49a0106f912a2ebd7fa0b5396d80fe..272e405985903cc32f025bd00ce61c0ed7232b14 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

@@ -80,8 +80,8 @@ class TestPageLoadMetricsEmbedderInterface

}

void set_is_ntp(bool is_ntp) { is_ntp_ = is_ntp; }

void RegisterObservers(PageLoadTracker* tracker) override {

- tracker->AddObserver(base::WrapUnique(new TestPageLoadMetricsObserver(

- &updated_timings_, &complete_timings_, &observed_committed_urls_)));

+ tracker->AddObserver(base::MakeUnique<TestPageLoadMetricsObserver>(

+ &updated_timings_, &complete_timings_, &observed_committed_urls_));

}

const std::vector<PageLoadTiming>& updated_timings() const {

return updated_timings_;